Use redis parse_url method instead of a custom one #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom method defined here has no real advantage - the redis lib implements it better and have support for many use cases - maintaining this implementation is error-prone and unnecessary work for overworked open-source contributors :) Especially, when you want to pass query parameters here, they are not supported (for eg a custom certificate authority)
|
@dkr-sahar thanks for the PR, if you can get the tests to pass I’ll accept and merge. |
|
Thanks for your sheer rapidity, I will try to achieve this goal in the best possible way @kencochrane I have spotted another issue for which I shall submit another PR afterwhile. |
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 92.93% 92.78% -0.16%
==========================================
Files 13 13
Lines 439 416 -23
==========================================
- Hits 408 386 -22
+ Misses 31 30 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It seems to have worked 👍 |
|
I was expecting the commits to be squashed automatically, but let me know if you want me to rewrite the history. |
|
Thank you, I can squash as it merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom method defined here has no real advantage
Especially, when you want to pass query parameters here, they are not supported (for eg a custom certificate authority)